JIT: remove getUnboxedEntry and getInstantiatedEntry#129285
Open
hez2010 wants to merge 3 commits into
Open
Conversation
github-actions
Bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR removes the getUnboxedEntry / getInstantiatedEntry ICorJitInfo host APIs and instead plumbs unboxed-entry information through resolveVirtualMethod, updating the JIT, CoreCLR host, and SuperPMI tooling accordingly.
Changes:
- Populate
resolvedTokenDevirtualizedUnboxedMethodduring devirtualization and update JIT call/unboxing logic to consume it. - Remove
getUnboxedEntryandgetInstantiatedEntryfrom the public JIT/EE interface and all generated wrappers/shims. - Update SuperPMI recording/replay infrastructure and bump the JIT/EE versioning GUID.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/vm/jitinterface.cpp | Sets unboxed-entry method handle on devirtualization result. |
| src/coreclr/inc/corinfo.h | Removes APIs and documents new unboxed resolved-token behavior. |
| src/coreclr/jit/importercalls.cpp | Switches unboxed-entry transformation logic to use resolved token + signature inspection. |
| src/coreclr/jit/indirectcalltransformer.cpp | Uses unboxed method handle from resolved token for GDV inline demotion logic. |
| src/coreclr/jit/inline.h | Removes separate unboxed-entry handle storage; relies on resolved token. |
| src/coreclr/inc/jiteeversionguid.h | Bumps interface GUID for breaking API change. |
| src/coreclr/tools/superpmi/** | Removes the two API calls from interception/record/replay and related packet definitions. |
| src/coreclr/tools/aot/jitinterface/jitinterface_generated.h | Removes callbacks/wrapper methods for the deleted APIs. |
| src/coreclr/tools/Common/JitInterface/* | Updates thunk generator inputs and managed interop to drop deleted APIs. |
Comment on lines
+8883
to
+8890
| // If we devirtualized into an unboxing stub, also hand back the unboxed entry | ||
| // so the jit can perform the unboxing transformation. | ||
| // | ||
| if (pDevirtMD->IsUnboxingStub()) | ||
| { | ||
| MethodDesc* pUnboxedMD = pDevirtMD->GetMethodTable()->GetUnboxedEntryPointMD(pDevirtMD); | ||
| info->resolvedTokenDevirtualizedUnboxedMethod.hMethod = (CORINFO_METHOD_HANDLE) pUnboxedMD; | ||
| } |
This was referenced Jun 11, 2026
Open
Contributor
Author
|
@jakobbotsch CI seems passing, but I guess this will need a pri1 test run to exercise more coverages. |
Contributor
Author
|
It seems that spmi gets skipped due to jit-ee interface changes. Trigger a MihuBot to check if it's zero diff. |
Contributor
Author
Comment on lines
+8886
to
+8890
| if (pDevirtMD->IsUnboxingStub()) | ||
| { | ||
| MethodDesc* pUnboxedMD = pDevirtMD->GetMethodTable()->GetUnboxedEntryPointMD(pDevirtMD); | ||
| info->resolvedTokenDevirtualizedUnboxedMethod.hMethod = (CORINFO_METHOD_HANDLE) pUnboxedMD; | ||
| } |
| Packet_CompareTypesForCast = 163, | ||
| Packet_CompareTypesForEquality = 164, | ||
| Packet_GetUnboxedEntry = 165, | ||
| //Packet_GetUnboxedEntry = 165, |
| Packet_GetSZArrayHelperEnumeratorClass = 226, | ||
| Packet_GetMethodInstantiationArgument = 227, | ||
| Packet_GetInstantiatedEntry = 228, | ||
| //Packet_GetInstantiatedEntry = 228, |
Contributor
Author
|
Zero diff as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup
getUnboxedEntryandgetInstantiatedEntryand all their usages, so that we no longer need a round-trip between the JIT and EE.cc: @jakobbotsch